The second file I looked at was this. Near 0 documentation - I counted about 8 lines (mostly noninformative like a comment stating that a global variable is a global variable) for 700 lines of code, magic numbers all over the place, incredible variable names like lgid, gid, cgid, c, ectx, dctx, p, prog, and e. I haven't checked out the actual code logic yet, but yeesh. I started with the Department of Energy since that's where presumably some of the more mission critical code would come from.
I always wondered how the government could manage to spend millions if not billions of dollars on relatively simple projects and still have them blow up.
4 comments
2 u/rwbj 08 Nov 2016 05:06
The second file I looked at was this. Near 0 documentation - I counted about 8 lines (mostly noninformative like a comment stating that a global variable is a global variable) for 700 lines of code, magic numbers all over the place, incredible variable names like lgid, gid, cgid, c, ectx, dctx, p, prog, and e. I haven't checked out the actual code logic yet, but yeesh. I started with the Department of Energy since that's where presumably some of the more mission critical code would come from.
I always wondered how the government could manage to spend millions if not billions of dollars on relatively simple projects and still have them blow up.
1 u/tame 08 Nov 2016 07:11
With a name like munge.c what did you expect? :P
Edit: If you want documentation, maybe start with the README?
0 u/klobos 08 Nov 2016 02:49
Well if their code is anything like what they wrote to implement the ACA, then it is all bloated crap fit only as a lesson in how not to code.
0 u/powerpete 08 Nov 2016 03:29
This is a incredible resource. Thanks for sharing!