For value checks generally use equals (). The == is for reference comparison. It depends upon, static, objects, primitive types, etc. Also you're adding five to point1, not returning 5 in this snippet.

if x == y and y == z then x will be == to z, I think that's redundant. I don't think that would effect the problem however. I would setup a System.out.println() to see what the values are so you can determine why the logic is failing.

The x == z comparison is unnecessary. Also, why are you adding 5 to the existing value of point1, instead of just assigning it directly?

point1 might be already equal to 5 when you enter this condition. Use your debugger to see what's going on, or if your want to do it ghetto style, add a print statement that shows the values of x, y, and z whenever the code block under the if statement is entered.

I don't see anything wrong with it. I'd leave out the "&& x == z" as that's redundant, but it shouldn't cause any problems.

Some thoughts:

• Are x, y, and z all ints? This would all be very wrong if they were objects instead of primitives.
• Could something be going on in the earlier part of the if statement?
• You say "return a 5." I assume you mean "add 5 to point1" since this is obviously not returning anything. Could the value be added somewhere else in the code?

Are you wishing to compare values or references?

Also, I'm thinking associative property can be more efficient (sorry to sound like a stickler)

does it have to be one IF statement?

The only way I can see this failing is if the variables are Objects, rather than primitive types. I.e. if they are Integer, rather than int.

If they are Objects, then use:

else if(x.equals(y) && x.equals(z)) { point1 = point1 + 5; }

Like others have said, you can omit the third comparison as it is redundant. Obviously here you will have to be sure that x is not null too, or that if it is null, that y and z are also null.

There is also a possibility that the problem is in the preceding if statement, since this is an else/if. Hard to say without seeing more of the code though.

If your description is accurate, it fails when point1 =5 before the statement starts as you're adding to point1 when it matches the conditional, and if youre expecting 5, the conditional only works when point1 starts as 0.

And you can get rid of x==z, as many have said.

(((Java)))

i recommend you to ask help with https://www.assignmentspot.co.uk/

This is the code preceding the else if, I don't see how it would effect i

  for (int counter=1; counter>0;){
     die1.roll();
     die2.roll();
     die3.roll();
     int x = die1.getFaceValue();
     int y = die2.getFaceValue();
     int z = die3.getFaceValue();
     if (x == round6 && y == round6 && z== round6)
     {

        point6 = point6 + 21;
        counter--;
     }

did you resolve the problem?

You could have used (x == y && x == z) as a condition, assuming primitive int-'s. The three-way expression resembles a swap idiom, but it is good to be explicit in the business logic however conceived.

I don't see what the previous (or later) conditionals in the if-else... chain are, execution probably branched to one of the other conditionals (i.e. (x == 5) taking a higher priority than than (x == y && x == z))

This is the complete code for the program, its a dice game called bunco where you gain points by dice rolls matching the round number, throwing three matching numbers, and throwing three matching numbers that match the round number. I added the extra x== z because the match 3 will occasionally give a + 5 even without anything matching but it still continues to do that.

Here is a link to the full code.

I am not a java expert

• Verify how getFaceValue(); is implemented. I am wondering if you return an int in here or are casting an object to an int value in this part: "int x = die1.getFaceValue();"
• There are 6 different "int x, y, z" that have the same name.
• You probably used copy&paste. I checked if you did not have typo's. Java works JIT I assume could an invisible character break the logic?

I think you should get to help an expert developer in Mujadidia.

I think this post helps you out https://www.mujadidia.com/java-programming-errors-that-must-be-sorted/.